On Sat, Oct 14, 2017 at 11:20:11AM +0900, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > >> Should we test that: > >> > >> git update-ref refs/heads/HEAD HEAD^ > >> > >> continues to work? > > > > Perhaps. Also we may want to make sure that "git branch -D HEAD" > > still works as a way to recover from historical mistakes. > > The only difference is improved tests where we use show-ref to make > sure refs/heads/HEAD does not exist when it shouldn't, exercise > update-ref to create and delete refs/heads/HEAD, and also make sure > it can be deleted with "git branch -d". Thanks, this looks good to me. -Peff