On 10/3/2017 5:51 PM, Ramsay Jones wrote:
Thanks, Ramsay. I applied these changes locally. I'll remember "static" in the future.Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> --- Hi Derrick, If you need to re-roll your 'ds/find-unique-abbrev-optim' branch, could you please squash this into the relevant patch (commit 3792c78ba0, "test-list-objects: list a subset of object ids", 01-10-2017). Thanks! ATB, Ramsay Jones t/helper/test-list-objects.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/t/helper/test-list-objects.c b/t/helper/test-list-objects.c index 22bc9b4e6..5c5d3c03f 100644 --- a/t/helper/test-list-objects.c +++ b/t/helper/test-list-objects.c @@ -6,43 +6,43 @@ struct count { int select_mod; };-int count_loose(const struct object_id *oid,- const char *path, - void *data) +static int count_loose(const struct object_id *oid, + const char *path, + void *data) { ((struct count*)data)->total++; return 0; }-int count_packed(const struct object_id *oid,- struct packed_git *pack, - uint32_t pos, - void* data) +static int count_packed(const struct object_id *oid, + struct packed_git *pack, + uint32_t pos, + void* data) { ((struct count*)data)->total++; return 0; }-void output(const struct object_id *oid,- struct count *c) +static void output(const struct object_id *oid, + struct count *c) { if (!(c->total % c->select_mod)) printf("%s\n", oid_to_hex(oid)); c->total--; }-int output_loose(const struct object_id *oid,- const char *path, - void *data) +static int output_loose(const struct object_id *oid, + const char *path, + void *data) { output(oid, (struct count*)data); return 0; }-int output_packed(const struct object_id *oid,- struct packed_git *pack, - uint32_t pos, - void* data) +static int output_packed(const struct object_id *oid, + struct packed_git *pack, + uint32_t pos, + void* data) { output(oid, (struct count*)data); return 0;
Thanks, -Stolee
