Git for Windows: mingw.c's strange usage of creation time as ctime?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



compat/mingw.c assigns the Windows file creation time [1] to Git's ctime fields at line 591 and at line 705:

buf->st_ctime = filetime_to_time_t(&(fdata.ftCreationTime));

ftCreationTime > ftLastWriteTime is actually possible after copying a file, so it makes sense to include this timestamp somehow in the Index, but I think it would be better to use the maximum of ftLastWriteTime and ftCreationTime here which is less confusing and closer to Unix's ctime:

buf->st_ctime = max(buf->st_mtime,
                    filetime_to_time_t(&(fdata.ftCreationTime));

-Marc

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa365739(v=vs.85).aspx




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux