Re: [PATCH 11/11] read-cache: roll back lock on error with `COMMIT_LOCK`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Martin Ågren <martin.agren@xxxxxxxxx> writes:

> Teach `write_locked_index(..., COMMIT_LOCK)` to roll back the lock
> before returning. If we have already succeeded and committed, it will be
> a noop. Simplify the existing callers where we now have a superfluous
> call to `rollback_lockfile()`. This should keep future readers from
> wondering why the callers are inconsistent.

Makes sense.  Thanks for cleaning up.  The split-index codepath was
something I've never reviewed seriously with fine toothed comb, and
I feel a lot better now knowing that somebody other than its authors
and me have read it through ;-)




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux