Hi Ben, On Mon, 18 Sep 2017, Ben Peart wrote: > > From: Johannes Schindelin [mailto:Johannes.Schindelin@xxxxxx] > > On Fri, 15 Sep 2017, Ben Peart wrote: > > > > > + DWORD(WINAPI *NtSetSystemInformation)(INT, PVOID, ULONG) = > > > + (DWORD(WINAPI *)(INT, PVOID, > > ULONG))GetProcAddress(ntdll, "NtSetSystemInformation"); > > > + if (!NtSetSystemInformation) > > > + return error("Can't get function addresses, wrong Windows > > > +version?"); > > > > It turns out that we have seen this plenty of times in Git for Windows' > > fork, so much so that we came up with a nice helper to make this all a bit > > more robust and a bit more obvious, too: the DECLARE_PROC_ADDR and > > INIT_PROC_ADDR helpers in compat/win32/lazyload.h. > > > > Maybe this would be the perfect excuse to integrate this patch into upstream > > Git? > > This patch is pretty hefty already. How about you push this capability > upstream and I take advantage of it in a later patch. :) Deal: https://public-inbox.org/git/f5a3add27206df3e7f39efeac8a3c3b47f2b79f2.1505834586.git.johannes.schindelin@xxxxxx Ciao, Johannes
