On 15/09/17 01:37, Jeff King wrote: > On Thu, Sep 14, 2017 at 12:31:38AM +0100, Ramsay Jones wrote: > >> I just tried it again tonight; the current master branch has 3532 >> warnings when compiled with -Wextra, 1409 of which are -Wsign-compare >> warnings. After applying the patch below, those numbers are reduced >> by 344 to 3188/1065. > > I'd love it if we were clean on -Wextra. My big question is many > contortions we'd have to go through in the code. I don't mind at all if > we're actually cleaning as we go (e.g., using types of the correct > signedness, or preventing possible funny interactions). I'm just worried > it will turn into a bunch of noisy casts. Hmm, my memory is not what it was, ... ;-) However, I seem to recall that most of the changes were "improvements", with only a (relatively) few scattering of casts (behind existing macros - namely the OPTION macros). (Oh, wait, I think 'unused' parameters etc., was another problem area). > The patch you showed seems like an improvement to the code, but I don't > know if that would be the case for all of them. :) Yes, I've had that patch (and others like it) hanging around for years! (perhaps it's time to dig through all those old branches) ATB, Ramsay Jones
