On Fri, Sep 08, 2017 at 12:37:28PM +0900, Junio C Hamano wrote:
> > I'm still moderately against storing generation numbers inside the
> > objects. They're redundant with the existing parent pointers, which
> > means it's an opportunity for the two sets of data to disagree. And as
> > we've seen, once errors are cemented in history it's very hard to fix
> > them, because you break any history built on top.
> >
> > I'm much more in favor of building a local cache of generation numbers
> > (either on the fly or during repacks, where we can piggy-back on the
> > existing pack .idx for indexing).
>
> I guess our mails crossed. Yes, objects that are needlessly broken
> only because they botch computation of derivable values are real
> problem, as we need to accomodate them forever because histories can
> and will be built on top of them.
>
> On the other hand, seeing that the world did not stop even with some
> projects have trees with entries whose mode are written with 0-padding
> on the left in the ancient part of their histories, it might not be
> such a big deal. I dunno.
True, but in counter-point:
1. Tree problems generally only affect operations on that tree itself.
Parent (or generation number) problems hit us any time we walk
across that part of history, which may be much more frequent.
2. There's an open question of what to do with existing commits
without generation numbers.
Per (1), "git tag --contains" is _always_ going to want to know the
generation number of v1.0. Some problems are "local" to their block
of history and as the project history marches forward, the bugs are
there but you are less likely to make queries that hit them. But
considering old tags for reachability will happen forever (and is
the _most_ important use of generation numbers, because it lets us
throw out that old history immediately).
So if we assume we can't rewrite those objects, then we end up with
some kind of local cache anyway.
3. I think we should be moving more in the direction of keeping
repo-local caches for optimizations. Reachability bitmaps have been
a big performance win. I think we should be doing the same with our
properties of commits. Not just generation numbers, but making it
cheap to access the graph structure without zlib-inflating whole
commit objects (i.e., packv4 or something like the "metapacks" I
proposed a few years ago).
-Peff
