On Thu, Sep 07, 2017 at 05:08:23PM +0100, Ramsay Jones wrote: > Hi Jeff, > > If you need to re-roll your 'jk/leak-checkers' branch, could you > please squash this into the relevant patch (commit c57586d954, > "add UNLEAK annotation for reducing leak false positives", 05-09-2017). > > This was noticed by sparse, since it is not declared when the > SUPPRESS_ANNOTATED_LEAKS pre-processor macro is not defined. > (You could move the declaration out of the #ifdef in the header > file, I suppose, but it seems pointless to compile the function > if it isn't being used). Thanks, that makes sense. There are a handful of other bits to modify in that final commit, so I will end up with at least one re-roll. -Peff