On 8/29/2017 11:06 PM, Jeff King wrote:
On Tue, Aug 29, 2017 at 04:08:25PM -0400, Jeff Hostetler wrote:
I just wanted to jump in here and say I've done some initial
testing of this against VSTS and so far it seems fine. And yes,
we have a custom git server.
Great, thank you for checking.
VSTS doesn't support the "git://" protocol, so the double-null trick
isn't an issue for us. But "https://"; worked just fine. I'm still
asking around internally whether we support passing SSH environment
variables.
The key thing for ssh is not whether you support passing environment
variables. It's whether you quietly ignore unknown variables rather than
cutting off the connection.
>
To support the v2 protocol you'd need to pass the new variables, but
you'd also need to modify your server to actually do something useful
with them anyway. At this point we're mostly concerned with whether we
can safely pass the variables to current implementations unconditionally
and get a reasonable outcome.
Right. I just spoke with our server folks and, currently, our SSH
support quietly eats ALL variables. So we're safe :-)
I'm starting a conversation with them to pass them thru so we can
be ready for this. (Assuming we choose to go this way.)
Thanks,
Jeff
