On Fri, Aug 18, 2017 at 11:24:47PM -0700, Junio C Hamano wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > > > From: Lars Schneider <larsxschneider@xxxxxxxxx> > > > > Do not override the submodule configuration in the call to update > > the submodules, but give a weaker default. > > > > Reported-by: Lars Schneider <larsxschneider@xxxxxxxxx> > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > > --- > > > > Personally I dislike this patch, but I have no better idea for the time > > being. > > The patch text from a cursory look seems reasonable to me. > > It's not like you have 47 different codepaths that need to pay > attention to the .update config and they all have to pass the new > --default-update option, this is merely to fix one of them that > relates to the problem reported by Lars, and you need a similar fix > to other 46, right? > > If you want the "--recurse-submodules" thing to always do the > "weaker default" thing in your project, you can choose not to set > .update to custom values in any of your submodules, so I do not > think the reason why you dislike this change is because it would > affect your use of submodules. > > So I am a bit curious to learn which part of this change you dislike > and why. I am also curious. Isn't this the same strategy we are using in other places? Cheers Heiko
