On Wed, Aug 09, 2017 at 11:29:30PM +0200, Nicolas Morey-Chaisemartin wrote: > > But the #ifdef above says 071700, which is 7.23.0. I wonder if we just > > got it wrong back then (maybe hex confusion with 7.17.0?). I have a > > build setup for old versions of curl, so I'll double-check that 7.19.4 > > builds with KEYPASSWD. And dig in the history to see if there's any > > comment on this mismatch. > > It seems to be a decimal/hex issue: > docs/libcurl/symbols-in-versions:153:CURLOPT_KEYPASSWD 7.17.0 > > I guess it should still work because it is now defined like this: > curl.h:#define CURLOPT_SSLKEYPASSWD CURLOPT_KEYPASSWD > > If I'm not mistaken on cpp behaviour it means CURLOPT_KEYPASSWD is > evaluated to CURLOPT_SSLKEYPASSWD (git define) which is evaluated into > CURLOPT_KEYPASSWD (curl define). > > It should stop here as CURLOPT_KEYPASSWD was not a defined macro when > the curl one was evaluated. It might be worth cleaning though, > specially it wouldn't work anymore if the git macro is ever moved > before the curl include. Hmph. That makes me think the original should have just been using CURLOPT_SSLKEYPASSWD through the code, if curl was providing a backwards-compatible macro. But it won't matter either way if we just get rid of it. :) Thanks for digging up the curl history. -Peff
