Le 09/08/2017 à 19:40, Junio C Hamano a écrit : > Jeff King <peff@xxxxxxxx> writes: > >> -#if LIBCURL_VERSION_NUM >= 0x071700 >> -/* Use CURLOPT_KEYPASSWD as is */ >> -#elif LIBCURL_VERSION_NUM >= 0x070903 >> -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD >> -#else >> -#define CURLOPT_KEYPASSWD CURLOPT_SSLCERTPASSWD >> -#endif >> - > This part I am not sure. Don't we still need to substitute > CURLOPT_KEYPASSWD with CURLOPT_SSLKEYPASSWD for versions below > 071700, e.g. 071000 which is 7.16.0? According to the documentation: https://curl.haxx.se/libcurl/c/CURLOPT_KEYPASSWD.html This option was known as CURLOPT_SSLKEYPASSWD up to 7.16.4 and CURLOPT_SSLCERTPASSWD up to 7.9.2. So the patch breaks things (broken for 7.16.[0-4]). But the series does not as the next patch ensure at least 7.19.4
