On Tue, Aug 08, 2017 at 09:54:53AM -0700, Junio C Hamano wrote: > > For comparison, nothing older than curl 7.19.4 will work for building > > Git since v2.12.0, as we added some unconditional uses of CURLPROTO_* > > there. Nobody seems to have noticed or complained. I pointed this out a > > few months ago[1] and suggested we clean up some of the more antiquated > > #if blocks in http.c that don't even build. There was some complaint > > that we should keep even these ancient versions working, but the > > compile error is still in "master". > > > > So it's not clear to me that anybody cares about going that far back > > (which is mid-2009), but I'd guess that 2013 might cause some problems. > > > > [1] https://public-inbox.org/git/20170404025438.bgxz5sfmrawqswcj@xxxxxxxxxxxxxxxxxxxxx/ > > if you're curious (you were offline for a while at that time, I > > think). > > Thanks for digging. It would not help the issue on this thread at > all. While I agree with your conclusion in the quoted thread: > > I think it might be nice to declare a "too old" version, though, > just so we can stop adding _new_ ifdefs. Maybe 7.11.1 is that > version now, and in another few years we can bump to 7.16.0. :) > > it appears that we silently declared it to 7.19.4 and found out that > nobody complained, without us having to wait for a few years? Yeah, I think the 7.19.4 breakage was discussed after I wrote that (and after investigating, I think the 7.16.0 cutoff is probably pretty reasonable even without that). I do think it's worth addressing. I just sent a series: https://public-inbox.org/git/20170809120024.7phdjzjv54uv5dpz@xxxxxxxxxxxxxxxxxxxxx/ -Peff
