On Mon, Jul 17, 2017 at 10:10:50PM +0200, Martin Ågren wrote: > test_expect_success TTY 'git tag -a respects --paginate' ' > test_when_finished "git tag -d newtag" && > rm -f paginated.out && > - test_terminal git -c pager.tag=false --paginate \ > - tag -am message newtag && > + test_terminal git --paginate tag -am message newtag && > + test -e paginated.out > +' This changes, I guess, because pager.tag should not be having any impact at all. So it would not hurt to leave it, but the in the final state of the test what is interesting is that "--paginate" kicks in. I do wonder if it could just drop the pager.tag bit when it is added in the first place. We test elsewhere that the command-line overrides the config (for a case that actually _does_ respect the config). I'm OK with it either way, though. -Peff
