On Mon, Jul 17, 2017 at 10:10:48PM +0200, Martin Ågren wrote: > diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh > index 20b4d83c2..e7430bc93 100755 > --- a/t/t7006-pager.sh > +++ b/t/t7006-pager.sh > @@ -134,6 +134,74 @@ test_expect_success TTY 'configuration can enable pager (from subdir)' ' > } > ' > > +test_expect_success TTY 'git tag -l defaults to not paging' ' > + rm -f paginated.out && > + test_terminal git tag -l && > + ! test -e paginated.out > +' I don't mind an expect_success like this, where it documents a sane and existing default, even if we're going to flip that default later in the series. But here... > +test_expect_success TTY 'git tag -a respects pager.tag' ' > + test_when_finished "git tag -d newtag" && > + rm -f paginated.out && > + test_terminal git -c pager.tag tag -am message newtag && > + test -e paginated.out > +' I think this behavior is just buggy, and it might be better introduced as a test_expect_failure on "git tag -a does not respect pager.tag". Kind of a minor nit, as the series should end up in the right place either way, but it can be helpful if you end up digging back in history to the introduction of the test. -Peff
