On Thu, Jun 15, 2017 at 11:46 PM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote: > On 06/16/2017 07:42 AM, Stefan Beller wrote: >> On Thu, Jun 15, 2017 at 7:47 AM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote: >>> This will later become a method of `packed_ref_store`. >> >> Also while touching it, maybe rename sha1 to object_hash >> (not saying object_id as that would be confusing with the actual >> oid struct), maybe? > > Hmmm, my impression was that most of the `unsigned char *` hashes are > still called sha1, and they are renamed to `oid` at the moment that they > are converted to `struct object_id *`. I only see two instances of the > string "object_hash" in the code: > > $ git grep object_hash > object.c:static void grow_object_hash(void) > object.c: grow_object_hash(); > > Michael Yeah maybe we can just defer it to the proper conversion series. I just jumped the gun here.