On 05/17/2017 07:26 PM, Stefan Beller wrote: > On Wed, May 17, 2017 at 5:05 AM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote: >> Extract function from `files_transaction_commit()`. It will soon have >> another caller. > > This sounds odd to me. Maybe it is missing words? > of s/function/the functionality to cleanup/ This is basically the same as the standard refactoring step "extract method", except applied to a function, not a method. I thought these terms would be standard enough to not need further explanation, but I'll add some more words. Michael