Re: [PATCH 11/23] files_transaction_cleanup(): new helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 11/23] files_transaction_cleanup(): new helper function
From: Stefan Beller <sbeller@xxxxxxxxxx>
Date: Wed, 17 May 2017 10:26:36 -0700
Cc: Junio C Hamano <gitster@xxxxxxxxx>, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>, David Turner <novalis@xxxxxxxxxxx>, "git@xxxxxxxxxxxxxxx" <git@xxxxxxxxxxxxxxx>
In-reply-to: <d6374d948f4424e4e6b4d999460597d226028be0.1495014840.git.mhagger@alum.mit.edu>
References: <cover.1495014840.git.mhagger@alum.mit.edu> <d6374d948f4424e4e6b4d999460597d226028be0.1495014840.git.mhagger@alum.mit.edu>

On Wed, May 17, 2017 at 5:05 AM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote:
> Extract function from `files_transaction_commit()`. It will soon have
> another caller.

This sounds odd to me. Maybe it is missing words?
of s/function/the functionality to cleanup/

Code makes sense to me.

Stefan

Follow-Ups:
- Re: [PATCH 11/23] files_transaction_cleanup(): new helper function
  - From: Michael Haggerty

References:
- [PATCH 00/23] Prepare to separate out a packed_ref_store
  - From: Michael Haggerty
- [PATCH 11/23] files_transaction_cleanup(): new helper function
  - From: Michael Haggerty

Prev by Date: Re: [PATCH 10/23] files_ref_store: put the packed files lock directly in this struct
Next by Date: Re: [PATCH 12/23] ref_transaction_commit(): break into multiple functions
Previous by thread: Re: [PATCH 11/23] files_transaction_cleanup(): new helper function
Next by thread: Re: [PATCH 11/23] files_transaction_cleanup(): new helper function
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]