"Michael S. Tsirkin" <mst@xxxxxxxxxxxxxxxxxx> writes: >> Quoting Alex Riesen <raa.lkml@xxxxxxxxx>: >> Subject: Re: [PATCHv2] connect: display connection progress >> >> On 5/10/07, Michael S. Tsirkin <mst@xxxxxxxxxxxxxxxxxx> wrote: >> >-static int git_tcp_connect_sock(char *host) >> >+static int git_tcp_connect_sock(char *host, int flags) >> >> There is only one bit of flags ever used. What are the others for? > > Hmm, I thought it's easier to read > git_tcp_connect_sock(host, NET_QUIET) > than > git_tcp_connect_sock(host, 1) > > but maybe that's overdesign. > >> Why use negative logic? >> What was wrong with plain "int verbose"? > > I want the default to report connections, and -q > to silence them. Maybe "int quiet"? I would really feel this extra verbosity should not be the default. Thanks. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
