On Thu, 10 May 2007, Alex Riesen wrote: > > There is only one bit of flags ever used. What are the others for? I actually think it tends to be better to have a "flags" field rather than a boolean, even if it only ends up having one flag. > Why use negative logic? This one I agree with. Ity would be nicer with CONNECT_VERBOSE than with NET_QUIET, and having the tests be if (flags & CONNECT_VERBOSE) .. instead. > What was wrong with plain "int verbose"? I could see wanting to add flags to do things like disable insecure connections etc, so there's certainly nothing saying that "verbose" is the only valid way to do things. > What addresses were tried by connect? That would be _really_ verbose. Maybe a CONNECT_EXTRA_VERBOSE? Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
