Re: [PATCH] t7400: add BSLASHPSPEC prerequisite to 'add with \\ in path'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 29/04/17 11:44, Johannes Schindelin wrote:

> On Sat, 29 Apr 2017, Johannes Sixt wrote:
>> Am 29.04.2017 um 02:15 schrieb Ramsay Jones:
>>> On 28/04/17 20:54, Johannes Sixt wrote:
>>>> Am 28.04.2017 um 05:09 schrieb Junio C Hamano:
>>>>> Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes:

>> I don't observe these failures. Are you using a vanila MSYS2 environment?
> 
> Please note that the "vanilla MSYS2 environment" is *not* expected to pass
> the test suite when compiling in MINGW mode. In fact, it is expected to
> fail.
> 
> In 2015, I made a couple of changes to the MSYS2 runtime in preparation
> for the big bump to Git for Windows 2.x (which switched from the old MSys
> environment to the new MSYS2 environment), and released Git for Windows
> 2.5.0 with a heavily patched msys-2.0.dll. My hope was that those changes
> would be welcome in the MSYS2 project, but well, they kinda weren't. So I
> was forced to abandon my original plan to contribute all of those fixes to
> "upstream MSYS2".

Oh WOW. I didn't know you were maintaining your own version of
the MSYS2 runtime. That must be a huge PITA. :-D

> To see the changes I (and others) made:
> 
> 	https://github.com/git-for-windows/msys2-runtime/compare/master%5E%7B/Start.the.merging.rebase%7D...master
> 
> I even started collecting the exact tests that are failing with the
> vanilla MSYS2 runtime vs Git for Windows' fork, when I still had hopes
> that we could test things with AppVeyor (but the builds were already too
> slow, we hit the timeout even before trying to run the tests, so I gave up
> on that front):
> 
> 	REM MSYS2's runtime does not carry Git for Windows' tweaks yet, so these
> 	tests cannot pass:
> 	set GIT_SKIP_TESTS='t0003 t0006 t0024 t1100 t1400 t1402 t1501 t1504 t1506
> 	t1508 t1513 t3001 t3070 t3200 t3301 t3400 t3404 t3513 t3703 t4116 t4150
> 	t4208 t4211 t5000 t5001 t5002 t5004 t5500 t5601 t5602 t5603 t5801 t6006
> 	t6018 t6041 t6130 t6132 t6300 t7201 t7400 t7501 t7502 t8002 t8006 t9001
> 	t9350 t9700 t9903'

I have only (fairly) recently installed MSYS2, so I've only ever
run the MinGW64 test-suite once, which for me failed on tests:

   t0003, t0006, t0026, t0060, t0200, t0204, t1100, t1400, t1402,
   t1501, t1504, t1506, t1508, t1513, t3001, t3070, t3200, t3301,
   t3400, t3404, t3406, t3703, t3903, t3905, t4208, t4211, t5000,
   t5500, t5516, t5601, t5602, t5603, t5615, t5801, t6006, t6018,
   t6030, t6038, t6130, t6132, t6300, t7201, t7400, t7401, t7406,
   t7501, t7610, t9001, t9020, t9350, t9700, t9903

(which I found somewhat intimidating!).

So, as you would expect, it hasn't improved much! :-P

Hmm, I was hoping to use this installation to test some git patches
on MinGW, but that looks like a lost cause. I may as well save some
disk space and delete it!

Thanks.

ATB,
Ramsay Jones





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]