Re: [PATCH] t7400: add BSLASHPSPEC prerequisite to 'add with \\ in path'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes:

> Commit cf9e55f494 ("submodule: prevent backslash expantion in submodule
> names", 07-04-2017) added a test which creates a git repository with
> some backslash characters in the name. This test cannot work on windows,
> since the backslash is used as the directory separator. In order to
> suppress this test on cygwin, MinGW and Git for Windows, we add the
> BSLASHPSPEC prerequisite. (see also commits 6fd1106aa4 and c51c0da222).
>
> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> Hi Junio,
>
> I built v2.13.0-rc1 and ran the test-suite on cygwin this evening and
> had an additional failure, over and above the failures reported for
> v2.13.0-rc0, namely t7400.20. This patch elides that test for cygwin
> (and MinGW and GfW, so it would be good to hear success reports from
> both Johannes).
>
> Thanks!

Thanks.  Will queue and hopefully we can merge it to 'master' before
the next -rc.

>
> ATB,
> Ramsay Jones
>
>  t/t7400-submodule-basic.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
> index c2706fe47..0d83153f3 100755
> --- a/t/t7400-submodule-basic.sh
> +++ b/t/t7400-submodule-basic.sh
> @@ -273,7 +273,7 @@ test_expect_success 'submodule add with ./, /.. and // in path' '
>  	test_cmp empty untracked
>  '
>  
> -test_expect_success 'submodule add with \\ in path' '
> +test_expect_success BSLASHPSPEC 'submodule add with \\ in path' '
>  	test_when_finished "rm -rf parent sub\\with\\backslash" &&
>  
>  	# Initialize a repo with a backslash in its name



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]