On Thu, Apr 27, 2017 at 02:17:55PM -0700, Stefan Beller wrote: > >> Retire "compaction", and keep "indent" as an experimental feature. > >> The latter hopefully will be turned on by default in a future > >> release, but that should be done as a separate step. > > Maybe turning on this feature by default is the next step instead of > adding them to bash competition or making them available in plumbing > commands for the upcoming release. > > Then in a later release we could even remove the knobs to turn it off. Yeah, if we are going to proceed with making it the default, I'd rather do that than worry about adding frills that will eventually not matter. We could take Marc's patch to move the config to git_diff_basic_config() as an interim step, though. It gives people an escape hatch if they find that they need to disable the feature for some plumbing command. In that discussion, the only argument I could come up with against making it the default (or respecting it for plumbing) is that it may have an impact on patch-ids. I'm not sure I'm swayed by that, but I wanted to mention it to make sure we're deciding consciously not to care about it. -Peff