On Fri, Dec 16, 2016 at 5:30 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Although I do not think we should spend too much braincycles on this > one (we should rather just removing the older one soonish), I think > this patch is going in a wrong direction. I agree that "the last > one wins" is a bit hard to see (until you check with "git config -l" > perhaps) but it at least is predictable. With this patch, you need > to KNOW that indent wins over compaction, perhaps by knowing the > order they were developed, which demands a lot more from the users. > I don't think we have too many config options that interact in this way, so I understand that "last writing of a particular configuration" makes sense, but interactions between configs is something that would have never occurred to me. I'll send a patch to drop the compaction heuristic since I think we're all 100% in agreement that it is superseded by the new configuration (as no case has been shown where the new one is worse than compaction, and most show it to be better). Thanks, Jake