Johannes Schindelin wrote: >> On Tue, Apr 25, 2017 at 2:51 PM, Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote: >>> On 04/25/2017 02:04 PM, Stefan Beller wrote: >>>> Do we want to test for this use case in the future? [...] >>> I'm not sure of the value of including a test for this specific use case, >>> because Git normally does not create commit messages with no trailing >>> newlines. (To test this, I suspect I would need to use hash-object with a >>> specifically crafted commit object.) [...] > Just because Git usually does not create commit messages without trailing > newlines does not mean that it is a rare thing. We got bug reports about > this, so I think it is frequent enough that we could save time by adding > that test and avoid future bug reports/bug hunts. To put it another way: it wouldn't have been worth writing this patch if it wasn't worth keeping the behavior. So we do need a test. Thanks, Jonathan