On Tue, Apr 25, 2017 at 2:51 PM, Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote: > On 04/25/2017 02:04 PM, Stefan Beller wrote: >> >> Thanks for the fix. :) >> Do we want to test for this use case in the future? > > > Thanks! > > I'm not sure of the value of including a test for this specific use case, > because Git normally does not create commit messages with no trailing > newlines. (To test this, I suspect I would need to use hash-object with a > specifically crafted commit object.) Okay, makes sense to omit a test. In that case: Is it needed to hint at how this bug occurred in the wild? (A different Git implementation, which may be fixed now?)