Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes: > On 14/03/17 23:46, brian m. carlson wrote: >>>> >>>> Since the SHA1_HEADER include is not defined in such a case, developers >>>> see spurious errors when using these tools. Furthermore, while using a >>>> macro as the argument to #include is permitted by C11, it isn't >>>> permitted by C89 and C99, and there are known implementations which >>>> reject it. >>> > >> Junio, do you want to amend the commit message before you merge it? > > Yes, please! ;-) If only you were a few hours quicker. Let me see how bad the fallout is to revert the merge to 'next' and merge an amended version in. I _think_ the whole "Furthermore" sentence can go, since nobody complained since cef661fc ("Add support for alternate SHA1 library implementations.", 2005-04-21) started using the Makefile construct. Thanks.