Hi, brian m. carlson wrote: [...] > --- a/cache.h > +++ b/cache.h > @@ -10,8 +10,8 @@ > #include "trace.h" > #include "string-list.h" > #include "pack-revindex.h" > +#include "hash.h" > > -#include SHA1_HEADER For what it's worth, the bazel build tool doesn't like this '#include SHA1_HEADER' either. Your fix looks like a straightforward fix and we never encouraged directly customizing SHA1_HEADER. The other approaches discussed may also work but they don't add anything for my application (nor yours, I'd think). Conditional #includes are a pretty normal thing so I am fine with this more straightforward change. So Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> That said, if someone is excited about one of the other approaches then I don't object to them. Thanks, Jonathan