Linus Torvalds wrote: > > On Sun, 6 May 2007, Michael Spang wrote: >> @@ -461,7 +462,7 @@ static int read_directory_recursive(struct dir_struct *dir, const char *path, co >> memcpy(fullname + baselen, de->d_name, len+1); >> if (simplify_away(fullname, baselen + len, simplify)) >> continue; >> - if (excluded(dir, fullname) != dir->show_ignored) { >> + if ((exclude = excluded(dir, fullname)) != dir->show_ignored) { > > Style issue: please write this as > > exclude = excluded(dir, fullname); > if (exclude != dir->show_ignored) { > > instead. Okay. Will fixup after waiting a bit for more comments. Thanks, Michael Spang - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html