Michael Spang <mspang@xxxxxxxxxxxx> writes:
> Signed-off-by: Michael Spang <mspang@xxxxxxxxxxxx>
> ---
>
> Whoops.
>
> t/t7300-clean.sh | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
Oops indeed.
* This is not an "amend"; you are following up an earlier patch of
your own. Marking such a patch as "amend" is only confusing.
Please do not do it.
> test_expect_failure \
> 'clean.requireForce' \
> - "mkdir -p build docs &&
> - touch a.out src/part3.c docs/manual.txt obj.o build/lib.so &&
> - git-config clean.requireForce true &&
> + "git-config clean.requireForce true &&
> git-clean"
* Please do not do this. test_expect_failure, unless used for a
very simple single test, is almost always a bug. You would
not know which step of && chain failed, even though you may be
expecting the failure from the last one.
* I do not think a "this reformats every existing tests" patch
is needed nor wanted, but at least I'd like to see new scripts
and updates to the existing ones to be consistently formatted
like this:
test_expect_success 'name of the test' '
test body goes here &&
like this &&
and this
'
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html