On Fri, Feb 3, 2017 at 10:59 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Duy Nguyen <pclouds@xxxxxxxxx> writes: > >>> +$ git reset -p HEAD^ <1> >> >> For good practice, perhaps put "git diff --cached HEAD^" before "git commit". >> >> I tend to avoid "reset -p" and "checkout -p" though because sometimes >> it does not work. Not sure if it's just me, I think it may have >> something to do with splitting hunks. So I usually go with "reset >> HEAD^" then "add -p" and "commit -c HEAD@{1}" instead. > > Perhaps I am superstitious, but I do that, too. > > Doing this that way, the users do not need to learn "reset -p" or > "checkout -p" and only need to know "add -p", and not having to > learn two extra things is a big plus. On the other hand, it > requires the users to learn the reflog, but that knowledge extends > to the use outside of the -c option of "commit" command, so overall > I think it is a win. > > I didn't know about the "-c" option to git commit, that makes the add -p path a bit more straight forward. I'll re-word the example to use this new suggested flow. Thanks, Jake