On Tue, Jan 24, 2017 at 12:27 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes: >> >> I'm not sure I follow. If the user doesn't want to signoff during a >> rebase, they can simply not pass --signoff. If they do, they can not >> pass it. Am I missing something? > > alias. > > Which also means that there needs to be --no-signoff option that can > be given to countermand an earlier --signoff, if a user did > > [alias] rb = rebase --signoff > > and wants to disable it one time only with > > $ git rb --no-signoff Oh, right, good point. This should be easy, I'll give this a go. >>> In any case, will queue as-is so that we won't lose the patch while >>> waiting for people to raise their opinions. >> >> Thanks. > > Thanks. The final version would also need tests, so it may be a > good time to start thinking about what aspect of this feature wants > to be protected against future breakages. I have troubles thinking how it could go wrong. The most obvious thing I can think of is it could not be remembered after an interruption+continue. I'll think about this some more. -- Giuseppe "Oblomov" Bilotta