On Thu, Jan 19, 2017 at 12:12:47PM -0800, Junio C Hamano wrote: > > The config-scope thing above would allow "remote.svn.vcs" in > > ~/.gitconfig. But I don't think the test script actually checks that; it > > checks for the repo-level config. And we would continue to do the right > > thing there. > > I am not "you" you are addressing to, but I think tying it to where > the variable came from makes quite sense. > > Because it makes it no longer possible to just inspect the > configured result to answer "is the remote configured?", > introduction of the configured field also needs to be preserved from > the original by Dscho, so does reading from historical non-config > sources like $GIT_DIR/remotes/*, which are by definition > per-repository thing. > > IOW, with this tweak (and not setting ->configured based on what > keys are set), I think Dscho's patch makes sense. Yeah, worry if that wasn't clear: the hunk I posted was a just a partial. The actual thing I built and ran against the test suite was exactly as you described. -Peff