On Tue, 17 Jan 2017 12:29:23 +0100 (CET) Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > In > > https://github.com/git/git/blob/master/git-gui/lib/choose_repository.tcl#L242 > > the procedure `_unset_recentrepo` is called, however the procedure > > isn't declared until line 248. My reading of the various Tcl > > tutorials suggest (but not explictly) that this isn't the right way. > > Indeed, calling a procedure before it is declared sounds incorrect. [...] > And it is perfectly legitimate to use not-yet-declared procedures in > other procedures, otherwise recursion would not work. [...] Sorry for chiming in too late, but I'd throw a bit of theory in. Since Tcl is an interpreter (though it automatically compiles certain stuff to bytecode as it goes through the script, and caches this representation), everything is interpreted in the normal script order -- top to bottom as we usually see it in a text editor. That is, there are simply no declaration vs definition: the main script passed to tclsh / wish is read and interpreted from top to bottom; as soon as it calls the [source] command, the specified script is read and interpreted from top to bottom etc; after that the control is back to the original script and its interpretation continues. Hence when Tcl sees a command (everything it executes is a command; this includes stuff like [proc], [foreach] and others, which are syntax in other languages) it looks up this command in the current list of commands it knows and this either succeeds or fails. The built-in command [proc] defines a new Tcl procedure with the given name, and registers it in that list of known commands. So the general rule for user-defined procedures is relatively straightforward: to call a procedure, the interpreter should have read and executed its definition before the attempted call.