I'm looking into a user git-gui problem (https://github.com/git-for-windows/git/issues/1014) that I'd seen in the past - I'd started some patches back in Dec 2015 http://public-inbox.org/git/1450310287-4936-1-git-send-email-philipoakley@xxxxxxx/ I'm trying to make sure I have covered the corner cases correctly, and I'm not sure if the current code actually works as advertised. In https://github.com/git/git/blob/master/git-gui/lib/choose_repository.tcl#L242 the procedure `_unset_recentrepo` is called, however the procedure isn't declared until line 248. My reading of the various Tcl tutorials suggest (but not explictly) that this isn't the right way. Should 3c6a287 ("git-gui: Keep repo_config(gui.recentrepos) and .gitconfig in sync", 2010-01-23) have declared `proc _unset_recentrepo {p}` before `proc _get_recentrepos {}` ? -- Philip