Hi Junio, On Tue, 20 Dec 2016, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > That code works because winansi_get_osfhandle() is in winansi.c, where its > > call to isatty() is *not* redirected to winansi_isatty(). Good. > > ... > > My plan was actually ... > > ... > > Let's just clean up all of this in one go. > > I take this to mean that I should hold off applying/merging j6t's > one liner and wait for your counterproposal tested by j6t. If I > misread you please let me know. > > Thanks for working well together, as always. I prepared a patch series based on `pu`, on top of Hannes' patch, and I also prepared a branch that is based on `master`, obviously without Hannes' patch. I am indifferent whether to include it or not, as long as we have something robust in the end that everybody is happy with. Ciao, Dscho