On Thu, Dec 8, 2016 at 3:58 PM, Brandon Williams <bmwill@xxxxxxxxxx> wrote: > The current implementation of real_path uses chdir() in order to resolve > symlinks. Unfortunately this isn't thread-safe as chdir() affects a > process as a whole and not just an individual thread. Instead perform > the symlink resolution by hand so that the calls to chdir() can be > removed, making real_path one step closer to being reentrant. > Better description for this part of the change. I like the improvement, as it clearly indicates what this particular patch is about, and why, but doesn't over-state what we gain here. The rest of this seems reasonable, though I'm not super familiar with the code, so I didn't have any comments. Thanks, Jake