Stefan Beller <sbeller@xxxxxxxxxx> writes: > + submodule_common_dir = strbuf_detach(&sb, NULL); > + ret = get_worktrees_internal(submodule_common_dir, flags); > + > + free(submodule_gitdir); This sequence felt somewhat unusual. I would have written this without an extra variable, i.e. ret = get_worktrees_internal(sb.buf, flags); strbuf_release(&sb);