On 12/07, Duy Nguyen wrote: > On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams <bmwill@xxxxxxxxxx> wrote: > > Convert 'show_recursive()' to use the pathspec struct interface from > > using the '_raw' entry in the pathspec struct. > > Slightly off-topic (sorry, but you made me look at this code! :D), > could you update the magic_mask argument of parse_pathspec() in this > file to PATHSPEC_ALL_MAGIC & ~(PATHSPEC_FROMTOP | PATHSPEC_LITERAL)? > It makes sure all future magic will be caught as unsupported (and I > think Stefan is adding one, but understandably he did not find this > code). > > I think it's in the spirit of renaming _raw to match too. By limiting > magic to fromtop and literal, we are sure match can only be path and > nothing else, which is good because this show_recursive can't handle > anything else either. Can do. -- Brandon Williams