Re: [PATCH 09/17] pathspec: always show mnemonic and name in unsupported_magic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams <bmwill@xxxxxxxxxx> wrote:
> @@ -413,10 +411,9 @@ void parse_pathspec(struct pathspec *pathspec,
>         prefixlen = prefix ? strlen(prefix) : 0;
>
>         for (i = 0; i < n; i++) {
> -               unsigned short_magic;
>                 entry = argv[i];
>
> -               item[i].magic = prefix_pathspec(item + i, &short_magic,
> +               item[i].magic = prefix_pathspec(item + i,
>                                                 flags,
>                                                 prefix, prefixlen, entry);

The final output looks a bit ...um.. strangely tall, with the first
two lines that have one argument each, then the last line comes with
three arguments. Maybe put 'flags' in the same line as 'item + i'?

>                 if ((flags & PATHSPEC_LITERAL_PATH) &&
>



-- 
Duy



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]