Hi Junio, On Tue, 22 Nov 2016, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > On Mon, 21 Nov 2016, Junio C Hamano wrote: > > > >> diff --git a/t/t0030-stripspace.sh b/t/t0030-stripspace.sh > >> index 29e91d861c..c1f6411eb2 100755 > >> --- a/t/t0030-stripspace.sh > >> +++ b/t/t0030-stripspace.sh > >> @@ -432,6 +432,15 @@ test_expect_success '-c with changed comment char' ' > >> test_cmp expect actual > >> ' > >> > >> +test_expect_failure '-c with comment char defined in .git/config' ' > >> + test_config core.commentchar = && > >> + printf "= foo\n" >expect && > >> + printf "foo" | ( > > > > Could I ask you to sneak in a \n here? > > The one before that _is_ about fixing incomplete line, but this and > the one before this one are not, so I think we should fix them at > the same time. > > But does it break anything to leave it as-is? If not, I'd prefer to > leave this (and one before this one) for a later clean-up patch post > release. Fair enough. As a matter of fact, we do not even need to change it later. If it ain't broke, don't fix it. Ciao, Dscho