Junio C Hamano <gitster@xxxxxxxxx> writes: >> +test_expect_failure '-c with comment char defined in .git/config' ' >> + test_config core.commentchar = && >> + printf "= foo\n" >expect && >> + printf "foo" | git stripspace -c >actual && > > We'd want "\n" on this printf to match the one before as well, as > this test is not about "does stripspace complete an incomplete > line?", I think. > > I could amend it while queuing, but I need to know if I am missing a > reason why this must be an incomplete line before doing so. > >> + test_cmp expect actual >> +' >> + > > Is this a recent regression? When applied on top of 'maint' or > older, it seems to pass just fine. I think we can force failure by running this test somewhere other than the top level of the working tree. A set of proposed amends incoming ...