On Tue, Nov 22, 2016 at 01:55:07PM -0800, Junio C Hamano wrote: > > And this test makes sense. Even without "sub", it would show the > > regression, but it's a good idea to test the sub-directory case to cover > > the path-munging. > > Yup. Obviously during my initial attempt I was scratching my head > wondering where these two files went--they were later found inside > t/ directory which was really bad ;-) Heh. Yeah, it's nice when the failure mode doesn't escape the trash directory, but it's probably not worth worrying about too much. > > In the "archive --remote" test I added, we may want to do the same to > > show that "--output" points at the correct path. > > Perhaps something like this. By going down one level, we make sure > that it is not sufficient to accidentally read from .git/config to > find out what 'foo' is, and also ../b5-nick.tar that is relative to > the prefix (aka 'a/') ends up at the top-level. Yeah, your modification looks good. -Peff