Jeff King <peff@xxxxxxxx> writes: >> +test_expect_success 'mailinfo with mailinfo.scissors config' ' >> + test_config mailinfo.scissors true && >> + ( >> + mkdir sub && >> + cd sub && >> + git mailinfo ../msg0014.sc ../patch0014.sc <../0014 >../info0014.sc >> + ) && >> + test_cmp "$DATA/msg0014--scissors" msg0014.sc && >> + test_cmp "$DATA/patch0014--scissors" patch0014.sc && >> + test_cmp "$DATA/info0014--scissors" info0014.sc >> +' > > And this test makes sense. Even without "sub", it would show the > regression, but it's a good idea to test the sub-directory case to cover > the path-munging. Yup. Obviously during my initial attempt I was scratching my head wondering where these two files went--they were later found inside t/ directory which was really bad ;-) > In the "archive --remote" test I added, we may want to do the same to > show that "--output" points at the correct path. Perhaps something like this. By going down one level, we make sure that it is not sufficient to accidentally read from .git/config to find out what 'foo' is, and also ../b5-nick.tar that is relative to the prefix (aka 'a/') ends up at the top-level. t/t5000-tar-tree.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh index 09df7f0458..830bf2a2f6 100755 --- a/t/t5000-tar-tree.sh +++ b/t/t5000-tar-tree.sh @@ -195,7 +195,10 @@ test_expect_success 'git archive --remote' \ test_expect_success 'git archive --remote with configured remote' ' git config remote.foo.url . && - git archive --remote=foo HEAD >b5-nick.tar && + ( + cd a && + git archive --remote=foo --output=../b5-nick.tar HEAD + ) && test_cmp_bin b.tar b5-nick.tar '