Re: [PATCH] git-svn: Don't rely on $_ after making a function call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Junio" == Junio C Hamano <junkio@xxxxxxx> writes:

Junio> I suspect Merlyn has better explanation, but...

Junio>      for (list) {
Junio> 	...	
Junio>      }

Junio> loop implicitly localizes $_ and does not share this problem,
Junio> which I really appreciate whenever I am writing Perl code, but
Junio> often enough I was bitten by scripts that use "while (<$fh>)",
Junio> which does not localizes $_, and made hard to spot bugs by
Junio> clobbering $_.

Junio> I find the patch a good safety measure for any future breakages.

I'm happy with the patch.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@xxxxxxxxxxxxxx> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]