On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote:
> +++ b/submodule.c
> @@ -500,6 +500,13 @@ static int has_remote(const char *refname, const struct object_id *oid,
> return 1;
> }
>
> +static int append_sha1_to_argv(const unsigned char sha1[20], void *data)
> +{
> + struct argv_array *argv = (struct argv_array *) data;
nit: no explicit cast needed when coming from a void pointer.