On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote:
> @@ -560,6 +575,31 @@ static void find_unpushed_submodule_commits(struct commit *commit,
> diff_tree_combined_merge(commit, 1, &rev);
> }
>
> +struct collect_submodule_from_sha1s_data {
> + char *submodule_path;
> + struct string_list *needs_pushing;
> +};
> +
> +static int collect_submodules_from_sha1s(const unsigned char sha1[20],
> + void *data)
> +{
> + struct collect_submodule_from_sha1s_data *me =
> + (struct collect_submodule_from_sha1s_data *) data;
nit: no explicit cast needed when coming from void* ?