gitweb html validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

There a small bug in gitweb html validation, you need the following patch to pass w3c check with searchbox enabled.

The problem lies in the input directly embed inside a form without a wrapper which is not valid.

Best regards

The following patch fix the issue for git-2.10.2 :
--- /usr/share/gitweb/gitweb.cgi.orig 2016-11-15 15:37:21.149805026 +0100 +++ /usr/share/gitweb/gitweb.cgi 2016-11-15 15:37:48.579240429 +0100
@@ -5518,6 +5518,7 @@ sub git_project_search_form {

        print "<div class=\"projsearch\">\n";
        print $cgi->start_form(-method => 'get', -action => $my_uri) .
+             '<div>'.
$cgi->hidden(-name => 'a', -value => 'project_list') . "\n"; print $cgi->hidden(-name => 'pf', -value => $project_filter). "\n"
                if (defined $project_filter);
@@ -5529,6 +5530,7 @@ sub git_project_search_form {
                             -checked => $search_use_regexp) .
              "</span>\n" .
              $cgi->submit(-name => 'btnS', -value => 'Search') .
+             '</div>'.
              $cgi->end_form() . "\n" .
$cgi->a({-href => href(project => undef, searchtext => undef, project_filter => $project_filter)},



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]