Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Sat, 29 Oct 2016 10:06:59 -0700
Cc: Junio C Hamano <gitster@xxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Git Mailing List <git@xxxxxxxxxxxxxxx>, Lars Schneider <larsxschneider@xxxxxxxxx>, Eric Wong <e@xxxxxxxxx>
In-reply-to: <alpine.DEB.2.20.1610291022120.3264@virtualbox>
References: <alpine.DEB.2.20.1610251327050.3264@virtualbox> <20161026201721.2pw4slsuyhxhcwxj@sigill.intra.peff.net> <xmqqd1imbymi.fsf@gitster.mtv.corp.google.com> <20161027102419.dbzigj7wtr355ofh@sigill.intra.peff.net> <CA+55aFwfhFqV74s_O=GucycY9U19ysiACDqX=mK4Gf=eQ0coxQ@mail.gmail.com> <xmqqoa254czs.fsf@gitster.mtv.corp.google.com> <CA+55aFxTHF4BRfcrCiV1D26-be+_rPhwAV+Vq8Roz-NMpPBadg@mail.gmail.com> <CA+55aFxdy4maom8byH0FoBBMWx+sQB8J7uWvHOxswjiaAhSjVg@mail.gmail.com> <xmqqfunh4b63.fsf@gitster.mtv.corp.google.com> <CA+55aFw83E+zOd+z5h-CA-3NhrLjVr-anL6pubrSWttYx3zu8g@mail.gmail.com> <xmqqa8dp46wx.fsf@gitster.mtv.corp.google.com> <xmqq60od42s0.fsf@gitster.mtv.corp.google.com> <alpine.DEB.2.20.1610281306320.3264@virtualbox> <CA+55aFw93vkraxBvFCXFSYJqn836tXW+OCOFuToN+HaxTcJ7cg@mail.gmail.com> <xmqqshrg1ksv.fsf@gitster.mtv.corp.google.com> <CA+55aFwUEzfvWVSZfhBi85QaKWSo-gVMOk1BJFrR0ZsdCRHRsg@mail.gmail.com> <xmqqr370vtba.fsf@gitster.mtv.corp.google.com> <alpine.DEB.2.20.1610291022120.3264@virtualbox>

On Sat, Oct 29, 2016 at 1:25 AM, Johannes Schindelin
<Johannes.Schindelin@xxxxxx> wrote:
>
> Correct. We cannot change an open file handle's state ("FD_CLOEXEC") on
> Windows, but we can ask open() to open said file handle with the correct
> flag ("O_CLOEXEC", which is mapped to O_NOINHERIT on Windows.

Ok. So then I have no issues with it, and let's use O_CLOEXEC if it
exists and fcntl(FD_CLOEXEC) if O_CLOEXEC doesn't exist.

              Linus

Follow-Ups:
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Junio C Hamano

References:
- Re: [PATCH v2 0/2] Use CLOEXEC to avoid fd leaks
  - From: Johannes Schindelin
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Jeff King
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Junio C Hamano
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Jeff King
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Linus Torvalds
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Junio C Hamano
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Linus Torvalds
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Linus Torvalds
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Junio C Hamano
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Linus Torvalds
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Junio C Hamano
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Junio C Hamano
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Johannes Schindelin
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Linus Torvalds
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Junio C Hamano
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Linus Torvalds
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Junio C Hamano
- Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
  - From: Johannes Schindelin

Prev by Date: Re: Fetch/push lets a malicious server steal the targets of "have" lines
Next by Date: Re: Fetch/push lets a malicious server steal the targets of "have" lines
Previous by thread: Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
Next by thread: Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]