Jakub Narębski <jnareb@xxxxxxxxx> writes:
> W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze:
>
>> diff --git a/sequencer.c b/sequencer.c
>> index 5ec956f..0614b90 100644
>> --- a/sequencer.c
>> +++ b/sequencer.c
>> @@ -623,7 +623,7 @@ static int do_pick_commit(enum todo_command command, struct commit *commit,
>> const char *base_label, *next_label;
>> struct commit_message msg = { NULL, NULL, NULL, NULL };
>> struct strbuf msgbuf = STRBUF_INIT;
>> - int res, unborn = 0, allow;
>> + int res = 0, unborn = 0, allow;
>
> Not that I am against this part of change, making initialization
> explicit, but why we are initializing automatic variables with 0,
> which would be the default value anyway?
Because an on-stack "auto" begins its life with an undefined value,
unlike a file-scope static (and global variables) that can be in BSS
segment.
> I thought our coding
> guidelines discourage initializing with 0 or NULL...
You are confused between the two, I am afraid.